Open
Conversation
terminates windows instance that runs for too long Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
with default configs in a file separate from the config definition. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Pull Request Overview
This PR titled "dev on rayci" introduces several new API types and functions to support user authentication and CI management, along with adding new CLI entry points and reverse proxy support.
- Introduces login-related API types (token, login, and logout requests/responses) in reefapi/login.go.
- Adds a new function to clean up dead Windows CI instances in reefd/reaper.go and enhances authentication flow in reefd/auth_gate.go.
- Provides new main packages for raycirun and doorway to support build orchestration and proxy functionality.
Reviewed Changes
Copilot reviewed 17 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| reefd/reefapi/login.go | New API types for login and logout requests/responses with minor grammar issues in comments. |
| reefd/reaper.go | Added function to terminate dead Windows instances using AWS SDK. |
| reefd/context_test.go | Test coverage for context-based user functions. |
| reefd/context.go | Context functions for propagating user information. |
| reefd/auth_gate.go | Authentication gate implementation with session handling. |
| raycirun/raycirun/main.go | New CLI entry point invoking raycirun package main functions. |
| raycirun/main.go | Main function for raycirun CLI managing build configurations. |
| doorway/main.go | Reverse proxy implementation using autocert for HTTPS support. |
Files not reviewed (12)
- doorway/_build/.dockerignore: Language not supported
- doorway/_build/.gitignore: Language not supported
- doorway/_build/Dockerfile: Language not supported
- doorway/build.sh: Language not supported
- go.mod: Language not supported
- reefd/_build/.dockerignore: Language not supported
- reefd/_build/.gitignore: Language not supported
- reefd/_build/config.hujson: Language not supported
- reefd/_dev/.gitignore: Language not supported
- reefd/_tmpl/index.html: Language not supported
- reefd/build.sh: Language not supported
- reefd/build_dev.sh: Language not supported
Comment on lines
+9
to
+10
| // SSHSignature is the signature structure of the verifying an token request | ||
| // that is signed with an SSH key. |
There was a problem hiding this comment.
[nitpick] Consider rephrasing the comment for clarity, for example: 'SSHSignature represents the signature used to verify a token request signed with an SSH key'.
Suggested change
| // SSHSignature is the signature structure of the verifying an token request | |
| // that is signed with an SSH key. | |
| // SSHSignature represents the signature used to verify a token request | |
| // signed with an SSH key. |
| Rest []byte `json:"rest,omitempty"` | ||
| } | ||
|
|
||
| // LoginRequest is the request to sign in as an user. |
There was a problem hiding this comment.
Replace 'an user' with 'a user' to correct the grammar.
Suggested change
| // LoginRequest is the request to sign in as an user. | |
| // LoginRequest is the request to sign in as a user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.